Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4598] Migrate Notification to TailwindCSS #4299

Merged
merged 18 commits into from
May 16, 2024

Conversation

AdrianContiu
Copy link
Contributor

@AdrianContiu AdrianContiu commented May 13, 2024

FX-4598

Description

This PR changes the Notification component to use the Snackbar from the MUI Base UI and applies styles using TailwindCSS.

Note:

  • There is also a change of the role attribute from alert to presentation. This was done due to an issue with the screen reader in Firefox. More details can be found here. It will also be included in the changeset file.
  • failed Happo tests are because the feature branch is out of date.

How to test

Screenshots

Before. After.
Picasso - Notification - Google Chrome 2024-05-13 at 11 04 38 AM Insert screenshots or screen recordings

Development checks

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@AdrianContiu AdrianContiu self-assigned this May 13, 2024
Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: 7d58f0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@toptal/picasso-notification Major
@toptal/picasso-forms Patch
@toptal/picasso-query-builder Patch
@toptal/picasso Patch
@toptal/picasso-page Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AdrianContiu AdrianContiu marked this pull request as ready for review May 14, 2024 10:10
@AdrianContiu AdrianContiu requested a review from a team as a code owner May 14, 2024 10:10
@TomasSlama TomasSlama force-pushed the fx-4598-migrate-snackbarcontent branch from 9d132a4 to bda9dad Compare May 14, 2024 10:13
Copy link
Collaborator

@OleksandrNechai OleksandrNechai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am concerned with twMerge usage, and !. When those are fixed or proven needed, I am good to go!

@toptal-devbot
Copy link
Collaborator

⚠️ Following packages are missing changesets. Please check if they don't require one.

@toptal/picasso-utils

@AdrianContiu AdrianContiu merged commit 29c6656 into feature/tw-snackbar May 16, 2024
14 checks passed
@AdrianContiu AdrianContiu deleted the fx-4598-migrate-snackbarcontent branch May 16, 2024 11:01
@AdrianContiu AdrianContiu restored the fx-4598-migrate-snackbarcontent branch May 17, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants