-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-4598] Migrate Notification to TailwindCSS #4299
[FX-4598] Migrate Notification to TailwindCSS #4299
Conversation
🦋 Changeset detectedLatest commit: 7d58f0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9d132a4
to
bda9dad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am concerned with twMerge usage, and !
. When those are fixed or proven needed, I am good to go!
packages/base/Notification/src/use-notification/use-notifications.tsx
Outdated
Show resolved
Hide resolved
|
FX-4598
Description
This PR changes the Notification component to use the Snackbar from the MUI Base UI and applies styles using TailwindCSS.
Note:
alert
topresentation
. This was done due to an issue with the screen reader in Firefox. More details can be found here. It will also be included in the changeset file.How to test
Screenshots
Development checks
Read CONTRIBUTING.md and Component API principlesAnnotate allprops
in component with documentationCreateexamples
for componentEnsure that deployed demo has expected results and good examplesEnsure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.Covered with tests (visual tests included)Breaking change
codemod is created and showcased in the changesettest alpha package of Picasso in StaffPortalPR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?