Add __eq__ method for Index instances
#311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fullonic
commented
Jul 26, 2023
| ).hexdigest() | ||
| def add_hash_eq_methods_to_index(idx): | ||
| def _hash(self): | ||
| return hash(self.index_name(cls.ddl.schema_generator, model).encode() + self.__class__.__name__.encode()) |
There was a problem hiding this comment.
@long2ice these hash arguments are enough to ensure that every change in the index configuration will generate a different one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #258
This issue happens because
new_indexes.difference(old_indexes)[code] andold_indexes.difference(new_indexes)[code] returns always all indexes, even when they are equal.This PR fixes this by adding the
__eq__to allIndexinstances. To ensure that indexes are equal we compare them using the__hash__method.