Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use narrower type for JSON.parse #140

Closed
wants to merge 1 commit into from
Closed

Use narrower type for JSON.parse #140

wants to merge 1 commit into from

Conversation

peterjwest
Copy link

Seems like using a narrower type here would be better, allowing users to do less type checking, since JSON is a pretty simple format.

Might also be worth exposing the JSON types for people to use.

I didn't attempt to update the docs, just putting forward the idea for now!

@mattpocock
Copy link
Collaborator

Thanks Pete! But closing because of the reasons specified in #10

#10

@mattpocock mattpocock closed this Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants