Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement Suggestions for the Repository #162

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

MDReal32
Copy link

@MDReal32 MDReal32 commented Aug 16, 2023

Hello! I've been following your content on YouTube and really appreciate the valuable information you share. Thank you for that!

I've taken the liberty to enhance the repository in a few ways:

  • Directory Structure Improvement: I've restructured the directories to make the project more organized and easier to navigate.
  • Build Script Enhancement: I've modified the build script and included a comment that updates the exports field in the package.json file. While I understand this might not align with best practices, I've kept this feature intact, leaving the decision to you. As an alternative, you might consider removing the exports field from package.json and allowing the CI process to generate it based on inputs.
  • Simplified Imports: Users can now import specific section using the following syntax: import ".../
    "; This makes imports more straightforward.
import "@total-typescript/ts-reset/array";
// or
import "@total-typescript/ts-reset/set";

These improvements aim to enhance the readability, maintainability, and usability of the repository. Please feel free to review these changes and adapt them according to your preferences. Your input is always valued. Thanks again for your fantastic content!

@NateLevin1
Copy link

Was the description of this PR generated by ChatGPT?
These changes are pretty substantial (almost entirely breaking changes), you may just want to keep your own fork instead of merging with this repository.

@MDReal32
Copy link
Author

MDReal32 commented Sep 2, 2023

No. Its not generated by ChatGPT. just fixed my grammatical problems. Yeah it braking changes. It can be released in next major update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants