Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve WidenLiteral #170

Closed
wants to merge 1 commit into from
Closed

Improve WidenLiteral #170

wants to merge 1 commit into from

Conversation

aswinsvijay
Copy link

No description provided.

@mattpocock
Copy link
Collaborator

One thing I'm worried about here is that without a certain target (ESNext works, ES2017 doesn't), bigint doesn't have a valueOf attribute.

@aswinsvijay
Copy link
Author

aswinsvijay commented Sep 19, 2023 •
edited

One thing I'm worried about here is that without a certain target (ESNext works, ES2017 doesn't), bigint doesn't have a valueOf attribute.

True, I could keep the bigint part as it was before, but that would affect the elegance of the solution.
Well it's not a solution if it doesn't work for everything now, is it? 🤷‍♂️

@mattpocock
Copy link
Collaborator

I guess not - I'm more comfortable with the uglier code that we know works. Feels like we could trip ourselves up easily here.

@mattpocock mattpocock closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aswinsvijay @mattpocock