New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add string-case types #25
Open
KajSzy
wants to merge
5
commits into
total-typescript:main
Choose a base branch
from
KajSzy:string-case
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaverden
reviewed
Mar 1, 2023
Co-authored-by: Denis Zavershinskiy <zaverden@gmail.com>
helmturner
reviewed
Mar 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't think of another language with upper- and lower-case letters to throw at it, but it's passing these tests (basically the same tests you wrote, but consolidated and made more exhaustive).
type EnglishLower = "abcdefghijklmnopqrstuvwxyz"
type EnglishUpper = "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
type CyrillicLower = "юабцдефгхийклмнопярстужвьызшэщчъ"
type CyrillicUpper = "ЮАБЦДЕФГХИЙКЛМНОПЯРСТУЖВЬЫЗШЭЩЧЪ"
doNotExecute(async () => {
doNotExecute(async () => {
const englishUpperString = "" as EnglishUpper;
const cyrillicUpperString = "" as CyrillicUpper;
const englishLowerString = englishUpperString.toLowerCase();
const cyrillicLowerString = cyrillicUpperString.toLowerCase();
const englishLocaleLowerString = englishUpperString.toLocaleLowerCase();
const cyrillicLocaleLowerString = cyrillicUpperString.toLocaleLowerCase();
type tests = [
Expect<Equal<typeof englishLowerString, EnglishLower>>,
Expect<Equal<typeof cyrillicLowerString, CyrillicLower>>,
Expect<Equal<typeof englishLocaleLowerString, EnglishLower>>,
Expect<Equal<typeof cyrillicLocaleLowerString, CyrillicLower>>,
Expect<NotEqual<typeof englishUpperString, typeof englishLowerString>>,
Expect<NotEqual<typeof cyrillicUpperString, typeof cyrillicLowerString>>,
Expect<NotEqual<typeof englishUpperString, typeof englishLocaleLowerString>>,
Expect<NotEqual<typeof cyrillicUpperString, typeof cyrillicLocaleLowerString>>,
];
});
});
doNotExecute(async () => {
const englishLowerString = "" as EnglishLower;
const cyrillicLowerString = "" as CyrillicLower;
const englishUpperString = englishLowerString.toUpperCase();
const cyrillicUpperString = cyrillicLowerString.toUpperCase();
const englishLocaleUpperString = englishLowerString.toLocaleUpperCase();
const cyrillicLocaleUpperString = cyrillicLowerString.toLocaleUpperCase();
type tests = [
Expect<Equal<typeof englishUpperString, EnglishUpper>>,
Expect<Equal<typeof cyrillicUpperString, CyrillicUpper>>,
Expect<Equal<typeof englishLocaleUpperString, EnglishUpper>>,
Expect<Equal<typeof cyrillicLocaleUpperString, CyrillicUpper>>,
Expect<NotEqual<typeof englishLowerString, typeof englishUpperString>>,
Expect<NotEqual<typeof cyrillicLowerString, typeof cyrillicUpperString>>,
Expect<NotEqual<typeof englishLowerString, typeof englishLocaleUpperString>>,
Expect<NotEqual<typeof cyrillicLowerString, typeof cyrillicLocaleUpperString>>,
];
});
…nto string-case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #16