Revert "Fixed 34 solution"

This reverts commit 7ac23db.
total-typescript · Aug 7, 2023 · e2ab313 · e2ab313
1 parent 7ac23db
commit e2ab313
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -11,7 +11,7 @@
     "cross-fetch": "^3.1.5",
     "jsdom": "^21.1.1",
     "prettier": "^2.8.7",
-    "typescript": "^5.1.6",
+    "typescript": "^5.0.3",
     "vite-tsconfig-paths": "^4.0.7",
     "vitest": "^0.31.1"
   },
@@ -107,4 +107,4 @@
   "dependencies": {
     "ts-toolbelt": "^9.6.0"
   }
-}
+}
diff --git a/src/06-challenges/34-internationalization.solution.ts b/src/06-challenges/34-internationalization.solution.ts
@@ -12,13 +12,13 @@ type GetParamKeysAsUnion<TTranslation extends string> =
 const translate = <
   TTranslations extends Record<string, string>,
   TKey extends keyof TTranslations,
-  TDynamicKeys = GetParamKeysAsUnion<TTranslations[TKey]>,
+  TDynamicKeys = GetParamKeysAsUnion<TTranslations[TKey]>
 >(
   translations: TTranslations,
   key: TKey,
-  ...args: [TDynamicKeys] extends [never]
-    ? []
-    : [dynamicArgs: Record<TDynamicKeys & string, string>]
+  ...args: TDynamicKeys extends string
+    ? [dynamicArgs: Record<TDynamicKeys, string>]
+    : []
 ) => {
   const translation = translations[key];
   const params: any = args[0] || {};