Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Access-Control-Allow-Private-Network #314

Closed
timothy-s-dev opened this issue Dec 12, 2022 · 2 comments
Closed

Support for Access-Control-Allow-Private-Network #314

timothy-s-dev opened this issue Dec 12, 2022 · 2 comments
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@timothy-s-dev
Copy link

Feature Request

Motivation

Chrome is removing/has removed the ability to send requests to private network endpoints from public websites:
https://developer.chrome.com/blog/private-network-access-preflight/

There is a pre-flight header it sends now (Access-Control-Request-Private-Network) and expects in the response to allow those requests through.

Proposal

Perhaps a new method alongside allow_headers/allow_methods/etc on CorsLayer (allow_private_network_access?) that provides the correct response header for the preflight request?

@davidpdrsn davidpdrsn added C-feature-request Category: A feature request, i.e: not implemented / a PR. E-help-wanted Call for participation: Help is requested to fix this issue. labels Dec 12, 2022
@jplatte jplatte self-assigned this Dec 12, 2022
@jplatte
Copy link
Collaborator

jplatte commented Feb 6, 2023

Help is still wanted, #315 is complete as far as the main logic is concerned, but is missing tests and I don't want to dedicate more time to it (I don't actually have a use case for this myself).

@jplatte
Copy link
Collaborator

jplatte commented Jul 19, 2023

Done in #373.

@jplatte jplatte closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants