Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for private network preflights #315

Closed
wants to merge 3 commits into from

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Dec 12, 2022

Fixes #314.

Needs a test, but I don't want to put in more time. Would be happy for somebody else to take over.

Copy link
Collaborator

@Nehliin Nehliin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some unit tests would be nice for this as well just as a sanity check

@jplatte
Copy link
Collaborator Author

jplatte commented Feb 6, 2023

I don't really want to dedicate more time to this beyond fixing trivial things. Should we add help-wanted somewhere so somebody else can take this over?

@Nehliin
Copy link
Collaborator

Nehliin commented Feb 6, 2023

Fair enough, sure that could make sense

@jplatte jplatte added the E-help-wanted Call for participation: Help is requested to fix this issue. label Mar 7, 2023
@jplatte jplatte removed the E-help-wanted Call for participation: Help is requested to fix this issue. label Jul 19, 2023
@jplatte
Copy link
Collaborator Author

jplatte commented Jul 19, 2023

Done in #373.

@jplatte jplatte closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Access-Control-Allow-Private-Network
2 participants