Support zstd (de)compression #322
Merged
+324
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
commented
Jan 20, 2023
| (false, true, false, true) => "deflate,zstd", | ||
| (false, false, true, true) => "br,zstd", | ||
| (false, false, false, true) => "zstd", | ||
| (false, false, false, false) => return None, |
There was a problem hiding this comment.
Not really sure what the priorities should be here.
There was a problem hiding this comment.
zstd is great, zstd first x)
(if that means it's preferred)
There was a problem hiding this comment.
Br is supposedly pretty good as well, and I guess more available than zstd?
There was a problem hiding this comment.
I wasn't really serious, by the way. But I agree with @Nehliin, if we want to sort by quality then br should also come before deflate and gzip.
Nehliin
requested changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #319