Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Default for DecompressionBody #370

Merged
merged 1 commit into from Jul 19, 2023
Merged

Implement Default for DecompressionBody #370

merged 1 commit into from Jul 19, 2023

Conversation

rtimush
Copy link
Contributor

@rtimush rtimush commented May 22, 2023

Motivation

It may be useful to have Default implemented for a body type. DecompressionBody used by the RequestDecompressionLayer can implement it if the inner body type does. The same Default implementation already exists for the CompressionBody, and there seems to be no reason why DecompressionBody shouldn't.

Solution

Add a Default implementation for DecompressionBody<B: Default>

Nehliin
Nehliin approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@Nehliin Nehliin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll get around to fixing CI sometime this week so probably won't be merged until then

@jplatte jplatte closed this Jul 19, 2023
@jplatte jplatte reopened this Jul 19, 2023
@jplatte jplatte enabled auto-merge (squash) July 19, 2023 08:36
@jplatte jplatte merged commit 21aa172 into tower-rs:master Jul 19, 2023
20 of 22 checks passed
@rtimush rtimush deleted the decompression-body-default branch July 19, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nehliin Nehliin Nehliin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rtimush @Nehliin @jplatte