Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Disable nightly CI runs #678

Closed
wants to merge 1 commit into from
Closed

Conversation

LucioFranco
Copy link
Member

Starting to see nightly fail with:

error[E0277]: `impl Send` is not a future
  --> examples/examples/tower-balance.rs:109:19
   |
109 |   fn gen_disco() -> impl Discover<
   |  ___________________^
110 | |     Key = Key,
111 | |     Error = Error,
112 | |     Service = ConcurrencyLimit<
113 | |         impl Service<Req, Response = Rsp, Error = Error, Future = impl Send> + Send,
114 | |     >,
115 | | > + Send {
   | |________^ `impl Send` is not a future
   |
   = help: the trait `std::future::Future` is not implemented for `impl Send`
   = note: impl Send must be a future or must implement `IntoFuture` to be awaited
   = note: required because of the requirements on the impl of `Service<Req>` for `ServiceFn<[closure@examples/examples/tower-balance.rs:121:45: 121:53]>`
   = note: required because of the requirements on the impl of `futures_core::stream::TryStream` for `Disco<ConcurrencyLimit<ServiceFn<[closure@examples/examples/tower-balance.rs:121:45: 121:53]>>>`
   = note: required because of the requirements on the impl of `tower::discover::Discover` for `Disco<ConcurrencyLimit<ServiceFn<[closure@examples/examples/tower-balance.rs:121:45: 121:53]>>>`

Which is a regression probably related to rust-lang/rust#99536, I think for now its fine to disable nightly while keeping beta and stable for version checks.

@LucioFranco LucioFranco requested a review from a team August 1, 2022 17:07
@LucioFranco LucioFranco closed this Aug 1, 2022
@LucioFranco LucioFranco deleted the LucioFranco-patch-1 branch August 1, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant