Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix permission denied error when lock file is placed in /tmp #317

Merged
merged 2 commits into from
Mar 25, 2024
Merged

[BugFix] fix permission denied error when lock file is placed in /tmp #317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32b0f74
remove os.O_CREAT when file already exists
kota-iizuka Mar 25, 2024
3dd97bc
use pathlib
kota-iizuka Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/filelock/_unix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import sys
from contextlib import suppress
from errno import ENOSYS
from pathlib import Path
from typing import cast

from ._api import BaseFileLock
Expand Down Expand Up @@ -35,7 +36,9 @@ class UnixFileLock(BaseFileLock):

def _acquire(self) -> None:
ensure_directory_exists(self.lock_file)
open_flags = os.O_RDWR | os.O_CREAT | os.O_TRUNC
open_flags = os.O_RDWR | os.O_TRUNC
if not Path(self.lock_file).exists():
open_flags |= os.O_CREAT
fd = os.open(self.lock_file, open_flags, self._context.mode)
with suppress(PermissionError): # This locked is not owned by this UID
os.fchmod(fd, self._context.mode)
Expand Down