Skip to content

Commit

Permalink
release 3.8.6
Browse files Browse the repository at this point in the history
  • Loading branch information
gaborbernat committed Apr 3, 2019
1 parent d073263 commit 20cb9a0
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 3 deletions.
10 changes: 10 additions & 0 deletions docs/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,16 @@ with advance notice in the **Deprecations** section of releases.

.. towncrier release notes start
v3.8.6 (2019-04-03)
-------------------

Bugfixes
^^^^^^^^

- :conf:`parallel_show_output` does not work with tox 3.8
`#1245 <https://github.com/tox-dev/tox/issues/1245>`_


v3.8.5 (2019-04-03)
-------------------

Expand Down
1 change: 0 additions & 1 deletion docs/changelog/1245.bugfix.rst

This file was deleted.

5 changes: 3 additions & 2 deletions src/tox/session/commands/run/parallel.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ def run_parallel(config, venv_dict):
with Spinner(enabled=show_progress) as spinner:

def run_in_thread(tox_env, os_env, processes):
output = None
env_name = tox_env.envconfig.envname
status = "skipped tests" if config.option.notest else None
try:
Expand All @@ -52,8 +53,6 @@ def collect_process(process):
callback=collect_process,
returnout=print_out,
)
if print_out:
reporter.verbosity0(output)

except InvocationError as err:
status = "parallel child exit code {}".format(err.exit_code)
Expand All @@ -68,6 +67,8 @@ def collect_process(process):
elif status is not None:
outcome = spinner.fail
outcome(env_name)
if print_out and output is not None:
reporter.verbosity0(output)

threads = deque()
processes = {}
Expand Down

0 comments on commit 20cb9a0

Please sign in to comment.