Skip to content

Commit

Permalink
Remove broken link (#3072)
Browse files Browse the repository at this point in the history
  • Loading branch information
gaborbernat committed Jul 31, 2023
1 parent b3fc5ca commit 5e28aff
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ repos:
rev: 1.15.0
hooks:
- id: blacken-docs
additional_dependencies: [black==23.3]
additional_dependencies: [black==23.7]
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: "v0.0.280"
hooks:
Expand Down
1 change: 1 addition & 0 deletions docs/changelog/3072.doc.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix broken links - by :user:`gaborbernat`.
9 changes: 4 additions & 5 deletions docs/development.rst
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,10 @@ must have legal permission to distribute any code you contribute to tox and it m
Provide tests that cover your changes and run the tests locally first. tox :ref:`supports <compatibility-requirements>`
multiple Python versions and operating systems. Any pull request must consider and work on all these platforms.

Pull requests should be small to facilitate review. Keep them self-contained, and limited in scope. `Studies have shown
<https://www.kessler.de/prd/smartbear/BestPracticesForPeerCodeReview.pdf>`_ that review quality falls off as patch size
grows. Sometimes this will result in many small PRs to land a single large feature. In particular, pull requests must
not be treated as "feature branches", with ongoing development work happening within the PR. Instead, the feature should
be broken up into smaller, independent parts which can be reviewed and merged individually.
Pull requests should be small to facilitate review. Keep them self-contained, and limited in scope. Studies have shown
that review quality falls off as patch size grows. In particular, pull requests must not be treated as
"feature branches", with ongoing development work happening within the PR. Instead, the feature should be broken up into
smaller, independent parts which can be reviewed and merged individually.

Additionally, avoid including "cosmetic" changes to code that is unrelated to your change, as these make reviewing the
PR more difficult. Examples include re-flowing text in comments or documentation, or addition or removal of blank lines
Expand Down
8 changes: 4 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ dependencies = [
"filelock>=3.12.2",
'importlib-metadata>=6.7; python_version < "3.8"',
"packaging>=23.1",
"platformdirs>=3.8.1",
"platformdirs>=3.9.1",
"pluggy>=1.2",
"pyproject-api>=1.5.3",
'tomli>=2.0.1; python_version < "3.11"',
'typing-extensions>=4.7.1; python_version < "3.8"',
"virtualenv>=20.23.1",
"virtualenv>=20.24.1",
]
optional-dependencies.docs = [
"furo>=2023.5.20",
Expand All @@ -76,8 +76,8 @@ optional-dependencies.testing = [
"covdefaults>=2.3",
"detect-test-pollution>=1.1.1",
"devpi-process>=0.3.1",
"diff-cover>=7.6",
"distlib>=0.3.6",
"diff-cover>=7.7",
"distlib>=0.3.7",
"flaky>=3.7",
"hatch-vcs>=0.3",
"hatchling>=1.17.1",
Expand Down

0 comments on commit 5e28aff

Please sign in to comment.