update how extras are extracted to handle cases with more than 2 groups #2812
+50
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
requested changes
Jan 3, 2023
|
Resorted to some |
gaborbernat
force-pushed
the
2791
branch
5 times, most recently
from
a1a56ce to
1588b35
Compare
gaborbernat
approved these changes
Jan 4, 2023
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
gaborbernat
approved these changes
Jan 4, 2023
descope bot
referenced
this pull request
in descope/django-descope
Jan 18, 2023
This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [tox](https://togithub.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | patch | `4.2.0` -> `4.2.1` | `4.3.4` (+11) | --- ### Release Notes <details> <summary>tox-dev/tox</summary> ### [`v4.2.1`](https://togithub.com/tox-dev/tox/releases/tag/4.2.1) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.2.0...4.2.1) #### What's Changed - update how extras are extracted to handle cases with more than 2 groups by [@​dconathan](https://togithub.com/dconathan) in [https://github.com/tox-dev/tox/pull/2812](https://togithub.com/tox-dev/tox/pull/2812) #### New Contributors - [@​dconathan](https://togithub.com/dconathan) made their first contribution in [https://github.com/tox-dev/tox/pull/2812](https://togithub.com/tox-dev/tox/pull/2812) **Full Changelog**: tox-dev/tox@4.2.0...4.2.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45OS4yIiwidXBkYXRlZEluVmVyIjoiMzQuOTkuMiJ9--> Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2791.
tox -e fix)docs/changelogfolderupdated/extended the documentation(n/a)This PR makes somewhat significant (?) changes to how extras are extracted from markers to accommodate situations where an extra falls into >2 extras groups (fixes #2791). The previous approach involved mutating the
_markerslist while iterating over it, which was problematic when dealing with longer lists. The new approach builds a new_markerslist.