The tests actually require wheel #2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
requested changes
Jan 9, 2023
hroncok
force-pushed
the
tests_need_wheel
branch
from
cddd95c
to
44fea38
Compare
gaborbernat
requested changes
Jan 9, 2023
When wheel is not installed, several tests error like this:
distutils.errors.DistutilsModuleError: invalid command 'bdist_wheel'
...
SystemExit: error: invalid command 'bdist_wheel'
Or like this:
ERROR Missing dependencies:
wheel
When the tests are executed in a virtualenv, wheel is implicitly installed,
which is why this have never happened on the CI.
List of tests that error:
ERROR tests/tox_env/python/virtual_env/package/test_package_cmd_builder.py::test_tox_install_pkg_wheel
ERROR tests/tox_env/python/virtual_env/package/test_package_cmd_builder.py::test_tox_install_pkg_sdist
ERROR tests/tox_env/python/virtual_env/package/test_package_cmd_builder.py::test_install_pkg_via[p]
ERROR tests/tox_env/python/virtual_env/package/test_package_cmd_builder.py::test_install_pkg_via[le]
ERROR tests/tox_env/python/virtual_env/package/test_python_package_util.py::test_load_dependency_no_extra
ERROR tests/tox_env/python/virtual_env/package/test_python_package_util.py::test_load_dependency_many_extra
Version 0.38.4 is required as this is the current version
and this is the way tox specifies the test dependencies.
hroncok
force-pushed
the
tests_need_wheel
branch
from
44fea38
to
c6eecdc
Compare
|
Added a bugfix changelog entry. |
gaborbernat
approved these changes
Jan 9, 2023
descope bot
added a commit
to descope/django-descope
that referenced
this pull request
Jan 28, 2023
This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [tox](https://togithub.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | patch | `4.2.6` -> `4.2.8` | `4.4.2` (+8) | --- ### Release Notes <details> <summary>tox-dev/tox</summary> ### [`v4.2.8`](https://togithub.com/tox-dev/tox/releases/tag/4.2.8) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.2.7...4.2.8) #### What's Changed - Allow package names with env markers with pip binary options by [@​q0w](https://togithub.com/q0w) in [tox-dev/tox#2853 **Full Changelog**: tox-dev/tox@4.2.7...4.2.8 ### [`v4.2.7`](https://togithub.com/tox-dev/tox/releases/tag/4.2.7) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.2.6...4.2.7) #### What's Changed - Add release notes project URL for quick access in PyPI web by [@​scop](https://togithub.com/scop) in [tox-dev/tox#2835 - Document colorization regression on Windows by [@​adamchainz](https://togithub.com/adamchainz) in [tox-dev/tox#2837 - The tests actually require wheel by [@​hroncok](https://togithub.com/hroncok) in [tox-dev/tox#2843 - Only return Python factor on base_python conflict by [@​stephenfin](https://togithub.com/stephenfin) in [tox-dev/tox#2840 - Revert to supporting simple Python factors by [@​stephenfin](https://togithub.com/stephenfin) in [tox-dev/tox#2849 **Full Changelog**: tox-dev/tox@4.2.6...4.2.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDEuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEwMS4wIn0=--> Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When wheel is not installed, several tests error like this:
Or like this:
When the tests are executed in a virtualenv, wheel is implicitly installed, which is why this have never happened on the CI.
List of tests that error:
Thanks for contribution
Please, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix)docs/changelogfolder