-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite substitution parser #2861
Merged
gaborbernat
merged 12 commits into
tox-dev:main
from
masenf:rewrite-substitution-parser
Jan 16, 2023
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
400f4c4
Double backslash should escape to backslash
masenf 44996c0
test_replace_os_sep_before_curly
masenf 9325d66
test_replace_env_when_value_is_backslash: replacement yields \
masenf 87986ed
test_replace_env_var_circular_flip_flop
masenf 20a6e6c
test_replace_env_default_deep
masenf 6b66f77
test_replace_env_var_chase: indirect refs
masenf 32dcacb
iterative and recursive parsing of replacement expression
masenf 36e7380
test_replace: fixup expectations and additional high level cases
masenf 9329377
docs/config.rst: add substitutions sections
masenf 64b961e
cr: changelog - fix issue number and mark as feature
masenf 3f66e3a
replace: MatchExpression clean up position tracking
masenf 2231986
cr: MatchError: docstring
masenf File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
Rewrite substitution replacement parser - by :user:`masenf` | ||
|
||
* ``\`` acts as a proper escape for ``\`` in ini-style substitutions | ||
* The resulting value of a substitution is no longer reprocessed in the context | ||
of the broader string. (Prior to this change, ini-values were repeatedly re-substituted until | ||
the expression no longer had modifications) | ||
* Migrate and update "Substitutions" section of Configuration page from v3 docs. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more a feature than bugfixe, as it changes behavior of the logic.