Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of version_added #2867

Merged
merged 1 commit into from Jan 16, 2023
Merged

Fix rendering of version_added #2867

merged 1 commit into from Jan 16, 2023

Conversation

kurtmckee
Copy link
Contributor

Noticed this while reading the documentation. This is currently rendered as raw text due to the incorrect indentation.

I read the checklist below but think this change is too small to warrant cloning the repo. Please let me know if you think otherwise, though!

Thanks for contribution

Please, make sure you address all the checklists (for details on how see
development documentation)!

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@jugmac00
Copy link
Member

jugmac00 commented Jan 16, 2023

Thank you! I am merging this as is, but imho every contribution is worth a change log item, so maybe consider creating a change log entry in the future.

@jugmac00 jugmac00 merged commit aeaba41 into tox-dev:main Jan 16, 2023
@kurtmckee
Copy link
Contributor Author

Understood. Moving forward, I'll clone the repo locally instead of modifying files in the GH web interface so I can add changelog items.

@kurtmckee kurtmckee deleted the patch-2 branch January 16, 2023 12:50
descope bot added a commit to descope/django-descope that referenced this pull request Jan 30, 2023
This PR contains the following updates:

| Package | Type | Update | Change | Pending |
|---|---|---|---|---|
| [tox](https://togithub.com/tox-dev/tox)
([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | patch |
`4.3.1` -> `4.3.2` | `4.4.2` (+5) |

---

### Release Notes

<details>
<summary>tox-dev/tox</summary>

### [`v4.3.2`](https://togithub.com/tox-dev/tox/releases/tag/4.3.2)

[Compare Source](https://togithub.com/tox-dev/tox/compare/4.3.1...4.3.2)

#### What's Changed

- Fix rendering of `version_added` by
[@&#8203;kurtmckee](https://togithub.com/kurtmckee) in
[tox-dev/tox#2867
- Fix a RestructuredText typo by
[@&#8203;kurtmckee](https://togithub.com/kurtmckee) in
[tox-dev/tox#2866
- Fix typos in `{tox_root}` variable name by
[@&#8203;kurtmckee](https://togithub.com/kurtmckee) in
[tox-dev/tox#2871
- Fix regression with multiple env substitutions for the same key by
[@&#8203;masenf](https://togithub.com/masenf) in
[tox-dev/tox#2873
- Fix a incorrect config key name by
[@&#8203;kurtmckee](https://togithub.com/kurtmckee) in
[tox-dev/tox#2868

#### New Contributors

- [@&#8203;kurtmckee](https://togithub.com/kurtmckee) made their first
contribution in
[tox-dev/tox#2867

**Full Changelog**: tox-dev/tox@4.3.1...4.3.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDEuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEwMS4wIn0=-->

Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants