Provision cwd #2877
Merged
Provision cwd #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using either a relative or absolute path to the conf file
running in a different working directory than the parent process changes the interpretation of relative paths on the command line passed to the provisoned tox and must be avoided. fix tox-dev#2876
gaborbernat
approved these changes
Jan 17, 2023
descope bot
added a commit
to descope/django-descope
that referenced
this pull request
Jan 31, 2023
This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [tox](https://togithub.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | patch | `4.3.3` -> `4.3.4` | `4.4.3` (+4) | --- ### Release Notes <details> <summary>tox-dev/tox</summary> ### [`v4.3.4`](https://togithub.com/tox-dev/tox/releases/tag/4.3.4) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.3.3...4.3.4) #### What's Changed - Provision cwd by [@​masenf](https://togithub.com/masenf) in [tox-dev/tox#2877 - Fix the type annotation for `color` param of `Spinner.finalize()` by [@​kurtmckee](https://togithub.com/kurtmckee) in [tox-dev/tox#2879 **Full Changelog**: tox-dev/tox@4.3.3...4.3.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDEuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEwMS4wIn0=--> Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing via the provisioning environment, run
toxin working directory of the parent process.Prior to this change (from tox 4.0.0), the provisioned
toxwould execute with{tox_root}as the working directory, which breaks when a relative path is passed to-cor--confandtoxis executed in a working directory other than{tox_root}.Fix #2876
Testing
The included integration test passes with the absolute path and fails with the relative path prior to this change.
Thanks for contribution
Please, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix)docs/changelogfolder