Fix the type annotation for color param of Spinner.finalize()
#2879
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colorama's ANSI class attributes are defined as ints. However, when an ANSI class is instantiated (say, when the `AnsiFore` class is instantiated as `Fore`), instance attributes with identical names are dynamically created, but the attributes are strings containing ANSI escape sequences. Thus, `AnsiFore.YELLOW` is an int, while `Fore.YELLOW` is a str. mypy 0.991 isn't catching this discrepancy, but PyCharm did. Fixes tox-dev#2878
descope bot
referenced
this pull request
in descope/django-descope
Jan 31, 2023
This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [tox](https://togithub.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | patch | `4.3.3` -> `4.3.4` | `4.4.3` (+4) | --- ### Release Notes <details> <summary>tox-dev/tox</summary> ### [`v4.3.4`](https://togithub.com/tox-dev/tox/releases/tag/4.3.4) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.3.3...4.3.4) #### What's Changed - Provision cwd by [@​masenf](https://togithub.com/masenf) in [https://github.com/tox-dev/tox/pull/2877](https://togithub.com/tox-dev/tox/pull/2877) - Fix the type annotation for `color` param of `Spinner.finalize()` by [@​kurtmckee](https://togithub.com/kurtmckee) in [https://github.com/tox-dev/tox/pull/2879](https://togithub.com/tox-dev/tox/pull/2879) **Full Changelog**: tox-dev/tox@4.3.3...4.3.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDEuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEwMS4wIn0=--> Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colorama's ANSI class attributes are defined as ints. However, when an ANSI class is instantiated (say, when the
AnsiForeclass is instantiated asFore), instance attributes with identical names are dynamically created, but the attributes are strings containing ANSI escape sequences.Thus,
AnsiFore.YELLOWis an int, whileFore.YELLOWis a str. mypy 0.991 isn't catching this discrepancy, but PyCharm did.Closes #2878.
Thanks for contribution
Please, make sure you address all the checklists (for details on how see
development documentation)!
ran the linter to address style issues (
tox -e fix)wrote descriptive pull request text
ensured there are test(s) validating the fix
mypy didn't notice a problem before or after the fix, so I don't see a way to test this.
added news fragment in
docs/changelogfolderupdated/extended the documentation
This doesn't seem necessary for this type of change. Please correct me if I'm wrong!