Include WHEEL metadata when using PDM and poetry backends #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the caller provides a metadata_directory, then put the contents into the
wheel (instead of the hardcoded metadata in the module).
From pyproject-api with modifications:
* correct the order of the `build_wheel` arguments according to PEP 517 to
work correctly with pyproject_hooks
* remove unnecessary `dedent` calls (these are applied during build)
missing WHEEL metadata with certain PEP 517 backends Fix tox-dev#2870
gaborbernat
approved these changes
Jan 18, 2023
|
Not sure about the docs failure on windows, will have to look at that a bit later. |
Passing empty `metadata_directory` to `build_wheel` or `build_editable` can cause some PEP 517 backends to create a wheel without metadata. Fix tox-dev#2880
masenf
force-pushed
the
build-wheel-metadata
branch
from
935e7eb
to
79d1b73
Compare
|
Thank you, @masenf and @gaborbernat! I'm very grateful for the fast work on this, and for your work on Tox! |
descope bot
added a commit
to descope/django-descope
that referenced
this pull request
Feb 1, 2023
This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [tox](https://togithub.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | patch | `4.3.4` -> `4.3.5` | `4.4.4` (+4) | --- ### Release Notes <details> <summary>tox-dev/tox</summary> ### [`v4.3.5`](https://togithub.com/tox-dev/tox/releases/tag/4.3.5) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.3.4...4.3.5) #### What's Changed - Include WHEEL metadata when using PDM and poetry backends by [@​masenf](https://togithub.com/masenf) in [tox-dev/tox#2881 **Full Changelog**: tox-dev/tox@4.3.4...4.3.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDEuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEwMS4wIn0=--> Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a
wheeloreditablepackage with a PEP 517 backend, no longer pass an emptymetadata_directoryto the backendbuild_wheelorbuild_editableendpoint.Some backends, such as PDM and poetry, will not generate package metadata in the presence of a
metadata_directory, even if it is empty.Prior to this change, attempting to install a wheel created by tox using PDM or poetry would return an error like
There is no item named 'my-package.0.1.dist-info/WHEEL' in the archiveFix #2880
Fix #2870
Thanks for contribution
Please, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix)docs/changelogfolder