Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more explanation to list_dependencies_command configuration option #2883

Merged
merged 5 commits into from Jan 19, 2023

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Jan 18, 2023

Whileing debugging different behavior of tests locally and on, CI I noticed thI, installed packages are listed on CI, and when running locally, they are not.

It make it harder to use diff tools. I need to go through the tox code to understand why it happens. So it is valuable to add information about the condition required to run a command from list_dependencies_command

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to fix the CI.

@Czaki
Copy link
Contributor Author

Czaki commented Jan 18, 2023

I was creating this PR outside my main machine without pre-commit installed. Sorry for such stupid typos that block CI.

@gaborbernat gaborbernat merged commit 7753e72 into tox-dev:main Jan 19, 2023
@gaborbernat
Copy link
Member

No worries, all good.

@Czaki Czaki deleted the add_doc_explanation branch January 20, 2023 10:15
descope bot added a commit to descope/django-descope that referenced this pull request Feb 8, 2023
This PR contains the following updates:

| Package | Type | Update | Change | Pending |
|---|---|---|---|---|
| [tox](https://togithub.com/tox-dev/tox)
([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | minor |
`4.3.5` -> `4.4.0` | `4.4.5` (+4) |

---

### Release Notes

<details>
<summary>tox-dev/tox</summary>

### [`v4.4.0`](https://togithub.com/tox-dev/tox/releases/tag/4.4.0)

[Compare Source](https://togithub.com/tox-dev/tox/compare/4.3.5...4.4.0)

#### What's Changed

- Add more explanation to `list_dependencies_command` configuration
option by [@&#8203;Czaki](https://togithub.com/Czaki) in
[tox-dev/tox#2883
- \[pre-commit.ci] pre-commit autoupdate by
[@&#8203;pre-commit-ci](https://togithub.com/pre-commit-ci) in
[tox-dev/tox#2889
- Enforce constraints during install_package_deps by
[@&#8203;masenf](https://togithub.com/masenf) in
[tox-dev/tox#2888
- Windows shlex fix by [@&#8203;masenf](https://togithub.com/masenf) in
[tox-dev/tox#2895

#### New Contributors

- [@&#8203;Czaki](https://togithub.com/Czaki) made their first
contribution in
[tox-dev/tox#2883

**Full Changelog**: tox-dev/tox@4.3.5...4.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDEuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEwMS4wIn0=-->

Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants