Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows shlex fix #2895

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Windows shlex fix #2895

merged 5 commits into from
Jan 25, 2023

Commits on Jan 25, 2023

  1. ini.replace: no longer escape \\ => \ 

    however the double backslash _is_ special in that in prevents the 2nd backslash
from escaping the following character. the reason for this is to allow shlex to
consume the double backslash during command splitting.
    @masenf
    masenf committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    fd63ca9 View commit details
    Browse the repository at this point in the history

  2. test_str_convert.py: platform-specific shlex cases

    @masenf
    masenf committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    e269307 View commit details
    Browse the repository at this point in the history

  3. str_convert: always use shlex POSIX mode 

    for less surprises, stick to shlex POSIX mode, regardless of the running platform.

on win32 platforms, explicitly convert a single backslash to double backslash,
unless the following character is "special"

fix tox-dev#2635

str_convert fixup

str_convert: always use shlex POSIX mode

for less surprises, stick to shlex POSIX mode, regardless of the running platform.

on win32 platforms, explicitly convert a single backslash to double backslash,
unless the following character is "special"

fix tox-dev#2635

str_convert fixup
    @masenf
    masenf committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    ec212fc View commit details
    Browse the repository at this point in the history

  4. test_str_convert: type fixups 

    export SubRequest from tox.pytest

add return type annotation to test fixture
    @masenf
    masenf committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    e48705b View commit details
    Browse the repository at this point in the history

  5. docs/config.rst: update substitution section 

    Add a note that backslashes remaining in the string after substitution will be
handled by shlex, noting platform-specific difference.
    @masenf
    masenf committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    39e561e View commit details
    Browse the repository at this point in the history