fix assertions in test_graph to actually test results #2906
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this as an example in an upcoming video -- the current code doesn't properly validate the exception messages for two reasons (1) the
|
character allows it to unintentionally match a substring (for exampleraise ValueError("A cycle was detected")
passes the test) and (2) thematch
argument usesre.search
to find the substring matchpersonally I recommend not using
match=
at all and instead assert based on theexcinfo
object -- but this is the minimal "correct" change without annoying the PT011 linter