Custom prefix in .ini source #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regression test for plugin behavior in tox-dev#2926
ensure that loaders returned from .ini source are bound to the correct section prefix, if specified. add comment explaining why the code must look up the name in the _section_mapping fix tox-dev#2926
for more information, see https://pre-commit.ci
gaborbernat
approved these changes
Feb 21, 2023
|
@masenf can you cut a release? Just run tox -e release -- version to trigger it. and then the CI will do the rest 😅 you can manually cut a GitHub release against the generated git tag as a final step. |
|
I need to learn to make releases sooner or later. Looks like you already handled 4.4.6 before I had a chance to pick it up. I'll try to get the next one, just to learn how it works. |
descope bot
added a commit
to descope/django-descope
that referenced
this pull request
Mar 7, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tox](https://togithub.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | patch | `4.4.5` -> `4.4.6` | --- ### Release Notes <details> <summary>tox-dev/tox</summary> ### [`v4.4.6`](https://togithub.com/tox-dev/tox/releases/tag/4.4.6) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.4.5...4.4.6) #### What's Changed - Add link to our own disucssion board by [@​jugmac00](https://togithub.com/jugmac00) in [tox-dev/tox#2921 - Custom prefix in .ini source by [@​masenf](https://togithub.com/masenf) in [tox-dev/tox#2927 **Full Changelog**: tox-dev/tox@4.4.5...4.4.6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDEuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEwMS4wIn0=--> Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug #2926.
For plugin developers to have more flexibility when loading configuration from tox.ini using the mechanisms provided by tox.
As an implementation note: I've tried to keep the door open for future support of generative environments for custom prefixes (factors) as well. it's not publicly plumbed through at the moment, but in the future, if the
_section_mappingcontained custom keys (perhaps expanded according to plugin logic), then it could auto-dispatch to a base environment just like a generativetestenvdoes.Thanks for contribution
Please, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix)docs/changelogfolder