Fix for requirements.txt using both --index-url and --find-links #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the fix, installation would fail with:
AttributeError: 'Namespace' object has no attribute 'find_links'
sk1p
force-pushed
the
bugfix-find-links-index-url
branch
from
d523236
to
46ad8f1
Compare
gaborbernat
approved these changes
Mar 26, 2023
descope bot
added a commit
to descope/django-descope
that referenced
this pull request
Apr 9, 2023
This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [tox](https://togithub.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | patch | `4.4.7` -> `4.4.8` | `4.4.11` (+2) | --- ### Release Notes <details> <summary>tox-dev/tox</summary> ### [`v4.4.8`](https://togithub.com/tox-dev/tox/releases/tag/4.4.8) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.4.7...4.4.8) #### What's Changed - Include `tox.ini` in sdist to fix tests by [@​mgorny](https://togithub.com/mgorny) in [tox-dev/tox#2939 - Bump pypa/gh-action-pypi-publish from 1.6.4 to 1.7.1 by [@​dependabot](https://togithub.com/dependabot) in [tox-dev/tox#2940 - docs: remove (dynamic) years from copyright by [@​paravoid](https://togithub.com/paravoid) in [tox-dev/tox#2941 - Bump pypa/gh-action-pypi-publish from 1.7.1 to 1.8.1 by [@​dependabot](https://togithub.com/dependabot) in [tox-dev/tox#2950 - Update documentation regarding `homedir` variable (upgrade to tox 4) by [@​aelray](https://togithub.com/aelray) in [tox-dev/tox#2955 - Bump pypa/gh-action-pypi-publish from 1.8.1 to 1.8.3 by [@​dependabot](https://togithub.com/dependabot) in [tox-dev/tox#2956 - Bump deps and tools by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/tox#2954 - docs: s/master/main/g in contributing docs by [@​sk1p](https://togithub.com/sk1p) in [tox-dev/tox#2960 - Fix for requirements.txt using both --index-url and --find-links by [@​sk1p](https://togithub.com/sk1p) in [tox-dev/tox#2959 #### New Contributors - [@​aelray](https://togithub.com/aelray) made their first contribution in [tox-dev/tox#2955 - [@​sk1p](https://togithub.com/sk1p) made their first contribution in [tox-dev/tox#2960 **Full Changelog**: tox-dev/tox@4.4.7...4.4.8 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDEuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEwMS4wIn0=--> Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the fix, installation would fail with:
when having both
--index-url(or--extra-index-url) and--find-linksin arequirements.txtfile. Order could also be important, I didn't check.Thanks for contribution
Please, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix)docs/changelogfolder