Avoid UnicodeDecodeError from command output #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SyncWrite decodes bytes as utf-8, it should replace unknown sequences with the unicode surrogate codepoint instead of crashing the program. Test case for tox-dev#2969
Avoid bubbling UnicodeDecodeError up from stream handling internals. Tox has no way of knowing that the bytestream emitted by a command will be valid utf-8, even if utf-8 is ostensibly the "correct" encoding for the stream. It's always possible for an arbitrary command to return non-utf-8 bytes, and this situation should not break tox. Fix tox-dev#2969
|
@gaborbernat @jugmac00 do either of you have an opinion on this change? |
gaborbernat
approved these changes
Apr 5, 2023
descope bot
added a commit
to descope/django-descope
that referenced
this pull request
Jun 11, 2023
This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [tox](https://togithub.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | minor | `4.4.8` -> `4.5.1` | `4.6.0` (+1) | --- ### Release Notes <details> <summary>tox-dev/tox</summary> ### [`v4.5.1`](https://togithub.com/tox-dev/tox/releases/tag/4.5.1): Test Trusted Publisher [Compare Source](https://togithub.com/tox-dev/tox/compare/4.5.0...4.5.1) ### [`v4.5.0`](https://togithub.com/tox-dev/tox/releases/tag/4.5.0) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.4.12...4.5.0) #### What's Changed - Bump deps and tools by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/tox#2987 - git: Ignore the .lock file for demo_pkg_inline by [@​hroncok](https://togithub.com/hroncok) in [tox-dev/tox#2988 - Add FAQ entry on how to test against EOL Python versions by [@​jugmac00](https://togithub.com/jugmac00) in [tox-dev/tox#2991 - Feature: suppress step timings for verbosity=1 [#​2891](https://togithub.com/tox-dev/tox/issues/2891) by [@​nedbat](https://togithub.com/nedbat) in [tox-dev/tox#2992 **Full Changelog**: tox-dev/tox@4.4.12...4.5.0 ### [`v4.4.12`](https://togithub.com/tox-dev/tox/releases/tag/4.4.12) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.4.11...4.4.12) #### What's Changed - Avoid race conditions in tests using the demo_pkg_inline fixture by [@​hroncok](https://togithub.com/hroncok) in [tox-dev/tox#2986 - Bump deps and tools by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/tox#2981 **Full Changelog**: tox-dev/tox@4.4.11...4.4.12 ### [`v4.4.11`](https://togithub.com/tox-dev/tox/releases/tag/4.4.11) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.4.10...4.4.11) #### What's Changed - Allow plugins to set `tox_root` by [@​kdestin](https://togithub.com/kdestin) in [tox-dev/tox#2978 #### New Contributors - [@​kdestin](https://togithub.com/kdestin) made their first contribution in [tox-dev/tox#2978 **Full Changelog**: tox-dev/tox@4.4.10...4.4.11 ### [`v4.4.10`](https://togithub.com/tox-dev/tox/releases/tag/4.4.10) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.4.9...4.4.10) #### What's Changed - Bump deps and tools by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/tox#2976 - Fix `tox_root` propagation to `work_dir` by [@​Tbruno25](https://togithub.com/Tbruno25) in [tox-dev/tox#2962 #### New Contributors - [@​Tbruno25](https://togithub.com/Tbruno25) made their first contribution in [tox-dev/tox#2962 **Full Changelog**: tox-dev/tox@4.4.9...4.4.10 ### [`v4.4.9`](https://togithub.com/tox-dev/tox/releases/tag/4.4.9) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.4.8...4.4.9) #### What's Changed - Added python 3.11 by [@​ElBe-Plaq](https://togithub.com/ElBe-Plaq) in [tox-dev/tox#2964 - Document running tox within a Docker container by [@​31z4](https://togithub.com/31z4) in [tox-dev/tox#2923 - Correct Docker image working dir by [@​31z4](https://togithub.com/31z4) in [tox-dev/tox#2965 - Avoid UnicodeDecodeError from command output by [@​masenf](https://togithub.com/masenf) in [tox-dev/tox#2970 - Bump pypa/gh-action-pypi-publish from 1.8.3 to 1.8.5 by [@​dependabot](https://togithub.com/dependabot) in [tox-dev/tox#2971 #### New Contributors - [@​ElBe-Plaq](https://togithub.com/ElBe-Plaq) made their first contribution in [tox-dev/tox#2964 - [@​31z4](https://togithub.com/31z4) made their first contribution in [tox-dev/tox#2923 **Full Changelog**: tox-dev/tox@4.4.8...4.4.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMC4yIiwidXBkYXRlZEluVmVyIjoiMzUuMTAuMiJ9--> Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of raising
UnicodeDecodeErrorwhen command output includes non-utf-8 bytes,toxwill now usesurrogateescapeerror handling to convert the unrecognized bytesto escape sequences according to PEP-383.
Tox has no way of knowing that the bytestream emitted by a command will be valid utf-8, even if utf-8 is ostensibly the "correct" encoding for the stream or system. It's always possible for an arbitrary command to return non-utf-8 bytes, and this situation should not break tox.
Thanks for contribution
Please, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix)docs/changelogfolder