Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure get_requires* hook is called before prepare_metadata* #3044

Merged
merged 10 commits into from
Jun 20, 2023
Merged

Ensure get_requires* hook is called before prepare_metadata* #3044

merged 10 commits into from
Jun 20, 2023

Commits on Jun 19, 2023

  1. Cache all hooks in Pep517VirtualEnvFrontend 

    This is useful when a hook is called multiple times (like
get_requires_for_build_wheel, which is called before
prepare_metadata_for_build_wheel and build_wheel).
    @abravalheri
    abravalheri committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    11fb7ab View commit details
    Browse the repository at this point in the history

  2. Extract build requires installation in Pep517VirtualEnvPackager 

    This method can then be re-used if we need to call
prepare_metadata_for_build_*.
    @abravalheri
    abravalheri committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    27f0148 View commit details
    Browse the repository at this point in the history

  3. Ensure get_requires* is called before prepare_metadata* 

    To improve compatibility with PEP 517, the dependencies should be
installed before the prepare_metadata* hooks are called.
    @abravalheri
    abravalheri committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    3148dd4 View commit details
    Browse the repository at this point in the history

  4. Fix linting

    @abravalheri
    abravalheri committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    d187671 View commit details
    Browse the repository at this point in the history

  5. Add changelog entry

    @abravalheri
    abravalheri committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    e2c01b2 View commit details
    Browse the repository at this point in the history

  6. Fix affected tests

    @abravalheri
    abravalheri committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    a67dc93 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. PR Feedback 

    Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
    @gaborbernat
    gaborbernat committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    6577d51 View commit details
    Browse the repository at this point in the history

  2. Improve bug fix message 

    Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
    @gaborbernat
    gaborbernat committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    2b158a5 View commit details
    Browse the repository at this point in the history

  3. Fix tests 

    Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
    @gaborbernat
    gaborbernat committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    b28ff7e View commit details
    Browse the repository at this point in the history

  4. More fixes 

    Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
    @gaborbernat
    gaborbernat committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    80ceb06 View commit details
    Browse the repository at this point in the history