Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skip_missing_interpreters with package=wheel #3152

Closed
wants to merge 2 commits into from

Conversation

gpotter2
Copy link

skip_missing_interpreters is broken when using package=wheel.

To reproduce

tox.ini

[tox]
skip_missing_interpreters = true
envlist = py{37,38,39,310,311,312}

[testenv]
package = wheel
allowlist_externals = echo
commands =
  echo "hey"

Note

This issue was basically already reported in #2811 under a slight different variation. I'm worried that there are still 30 other badly-tested edge cases where skip_missing_interpreters breaks.

Checks

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@gpotter2
Copy link
Author

gpotter2 commented Nov 12, 2023

Why. So it's normal for depends to show could not find python interpreter with spec(s): py31) even if skip_missing_interpreters=true. I don't understand this test so I'm giving up on fixing it myself.

See #3153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant