Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3165 fixed Tox failing with --installpkg and multi testenvs #3186

Merged
merged 4 commits into from Jan 16, 2024

Conversation

Stefanhg
Copy link
Contributor

As decided in the issue, disabling the feature was sufficient and no need for additional work.
I don't see any needs for additional documentation needed so left it unchecked.

  • [x ] ran the linter to address style issues (tox -e fix)
  • [x ] wrote descriptive pull request text
  • [x ] ensured there are test(s) validating the fix
  • [x ] added news fragment in docs/changelog folder
  • updated/extended the documentation

Disabled cleaning of .sdist-extract folder and added testcase to catch issue caused by feature.
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat enabled auto-merge (squash) January 16, 2024 20:03
@gaborbernat gaborbernat merged commit 37b11d4 into tox-dev:main Jan 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants