Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document usage of Pytest with Tox as a FAQ entry #3192

Merged
merged 4 commits into from Jan 18, 2024
Merged

Document usage of Pytest with Tox as a FAQ entry #3192

merged 4 commits into from Jan 18, 2024

Conversation

faph
Copy link
Contributor

@faph faph commented Jan 18, 2024 •
edited

Fixes #3187

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@faph
Copy link
Contributor Author

faph commented Jan 18, 2024

@gaborbernat Let me know what you think. This is loosely based on the Tox 3 docs with some additional detail in places.

gaborbernat
gaborbernat requested changes Jan 18, 2024
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

docs/faq.rst Outdated Show resolved Hide resolved
@faph faph requested a review from gaborbernat January 18, 2024 16:01
gaborbernat
gaborbernat approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 5054a86 into tox-dev:main Jan 18, 2024
25 checks passed
@faph faph deleted the docs/pytest-concurrency branch January 18, 2024 19:40
@faph
Copy link
Contributor Author

faph commented Jan 18, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document that temp dir tweaks should be applied when running Pytest in parallel with Tox
2 participants
@faph @gaborbernat