Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.cli.test_cli_ini: Re-order for clarity (textual moves only) #3209

Conversation

0cjs
Copy link
Contributor

@0cjs 0cjs commented Jan 28, 2024

No code changes; just a "move text" refactoring.

This makes the code quicker to understand by moving the exhaustive_ini fixture next to the two tests using it, rather than having it separated from them by several other test functions that don't use it. (This separation is why I didn't immediately see an important point in that in issue #3207.)

There's also a slight re-ordering of tests; they're still in an order that makes sense for testing the functionality from the smallest to the largest bits.

  • [✓] ran the linter to address style issues (tox -e fix)
  • [✓] wrote descriptive pull request text
  • [✓] ensured there are test(s) validating the fix
  • [n/a] added news fragment in docs/changelog folder
  • [n/a] updated/extended the documentation

No code changes; just a "move text" refactoring.

This makes the code quicker to understand by moving the exhaustive_ini
fixture next to the two tests using it, rather than having it separated
from them by several other test functions that don't use it. (This
separation is why I didn't immediately see an important point in that
in issue tox-dev#3207.)

There's also a slight re-ordering of tests; they're still in an order
that makes sense for testing the functionality from the smallest to
the largest bits.
@gaborbernat gaborbernat merged commit 2bcc3ec into tox-dev:main Jan 28, 2024
24 of 25 checks passed
@0cjs 0cjs deleted the dev/cjs/24a28/test-cli-ini-related-code-together branch January 29, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants