Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert previous "precommit autoupdate (#3214)" commit; it's broken #3215

Merged
merged 1 commit into from Feb 6, 2024

Conversation

0cjs
Copy link
Contributor

@0cjs 0cjs commented Feb 6, 2024

The top-level linter setting names in pyproject.toml have changed, and while this could accept the old names until they're fixed, it choses not to and fails the build.

Fixing that is easy, but results in yet more failures that were not previously appearing in unchanged code.

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • [n/a] ensured there are test(s) validating the fix
  • [n/a] added news fragment in docs/changelog folder
  • [n/a] updated/extended the documentation

…oken

The top-level linter setting names in pyproject.toml have changed, and
while this _could_ accept the old names until they're fixed, it choses not
to and fails the build.

Fixing that is easy, but results in yet more failures that were not
previously appearing in unchanged code.

- Revert "[pre-commit.ci] pre-commit autoupdate (tox-dev#3214)"
- This reverts commit 3347933.
@gaborbernat gaborbernat merged commit fb83a3a into tox-dev:main Feb 6, 2024
24 of 25 checks passed
@0cjs 0cjs deleted the dev/cjs/24b07/undo-autoupdate branch February 6, 2024 23:09
@0cjs
Copy link
Contributor Author

0cjs commented Feb 6, 2024

BTW, I notice that a lot of text is getting removed from commit messages when PR commits come on to main. For example, the commit message of the single commit for this PR was:

Revert previous "precommit autoupdate (#3214)" commit; it's broken

The top-level linter setting names in pyproject.toml have changed, and
while this _could_ accept the old names until they're fixed, it choses not
to and fails the build.

Fixing that is easy, but results in yet more failures that were not
previously appearing in unchanged code.

- Revert "[pre-commit.ci] pre-commit autoupdate (#3214)"
- This reverts commit 3347933a4e3d5cda8f993ffccc3f79b5a01a819c.

But in the commit that was actually put on main, it's just:

Revert previous "precommit autoupdate (#3214)" commit; it's broken (#3215)

I've seen similar in other PRs.

The original commit messages do still seem to remain available if you come back to the PR, but I suspect that they may disappear if I ever delete my fork repo containing the dev branch.

It's up to you, of course, but it might be worth keeping the full commit messages on the main branch as well, rather than trimming them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants