Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider complete envs, not factors #3220

Closed
wants to merge 1 commit into from

Commits on Feb 15, 2024

  1. Consider complete envs, not factors

    To determine whether we have been given a valid *env*, we compare the
    *factors* of the *env* to our known set of *factors*. If a testenv
    contains a series of valid factors, we assume the testenv is valid. This
    is an incorrect assumption: a testenv is only valid if it defined in the
    configuration file *or* is one of the "special" auto-generated testenvs
    like e.g. 'py310'. Correct this mistake.
    
    While we're here, we make use of verbose mode to explain our regex for
    matching "magic" factors better.
    
    Signed-off-by: Stephen Finucane <stephen@that.guru>
    Closes: tox-dev#3219
    stephenfin committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    9b0529c View commit details
    Browse the repository at this point in the history