Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple override appends #3261

Merged
merged 1 commit into from Apr 3, 2024

Conversation

amitschang
Copy link
Contributor

@amitschang amitschang commented Apr 3, 2024

Currently only the last override supplied is considered, in conflict with now supported append overrides ("+="). This now enables appending multiple times via the command line.

The docs are also misleading for dependencies, where seems to imply a comma-separated list of dependencies can be given in the override, but there is no handling of this (and there probably shouldn't be, since , is a possible character in version spec).

With this change, something like

tox -e env -x testenv.deps+=debugpy -x testenv.deps+=pytest

would be possible.

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog please

Currently only the last override supplied is considered, in conflict with now
supported append overrides ("+="). This now enables appending multiple times via
the command line.
@amitschang
Copy link
Contributor Author

@gaborbernat, done, thanks!

@gaborbernat gaborbernat enabled auto-merge (squash) April 3, 2024 21:58
@gaborbernat gaborbernat merged commit f5850c0 into tox-dev:main Apr 3, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants