fix: recursion error (max call stack size exceeded)

[hrueger]

Hi @toyobayashi,
I just updated my application from electron 17 to electron 20 and I suddenly started to get a Maximum call stack size exceeded error.
I don't have the exact stack trace anymore, but splitPath calls statSync and this calles splitPath again... This will go on forever until the maximum call stack size is exceeded.

I don't know what introduced this problem since I did not update asar-node, just other packages.
This PR, however, seems to fix it, although I don't know if that has sideeffects.

[toyobayashi]

@hrueger Thank you for your feedback.

I just updated my application from electron 17 to electron 20

You mean you are using asar-node in electron runtime environment?

The statSync here should have been the original fs.statSync, but I don't know why it becomes the overwritten one.

I don't recommend adding an outsideAsar option which changes the original function behavior

Could you provide a minimum reproduce code repo?

[hrueger]

You mean you are using asar-node in electron runtime environment?

Correct.

Could you provide a minimum reproduce code repo?

I'll see what I can do, but unfortunately not today. My application is quite complex.
Maybe it's interesting to know that I'm using the module in a worker_thread?

[hrueger]

Oh, thanks for the fix 👍
I'll test that right now and get back to you.

[toyobayashi]

electron/electron#33216 seems to be related to this problem.

Now I found 'electron' in process.versions is always false in worker threads. I didn't realize that asar-node always use require('fs') instead of require('original-fs') in electron's worker threads until now.

Perhaps electron/electron#33216 make require('fs') changed in worker threads, then caused this.

Before:

After:

[toyobayashi]

In my understand, the electron environment itself provides all the functionality of asar-node, why do you need to use asar-node in worker threads?

[hrueger]

I need to require modules in there and I remember that this did not work without asar-node... However, I'll try it without asar-node.

[hrueger]

I can happily report that your fix also works. Now I'll try without asar-node at all.

[toyobayashi]

I guess your code can work without asar-node on electron version >= 17.3.0, which have electron/electron#33216 merged.

[hrueger]

That makes sense, thanks for your help 👍
Yes, I was using electron v17.1.2 before.