Merge pull request #11 from toyobayashi/fix-unused-var

toyobayashi · Dec 14, 2022 · c47aab9 · c47aab9
2 parents 0fb5eb0 + b648530
commit c47aab9
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/packages/emnapi/src/emnapi.c b/packages/emnapi/src/emnapi.c
@@ -118,7 +118,9 @@ napi_status napi_adjust_external_memory(napi_env env,
   }
 
   size_t old_size = emscripten_get_heap_size();
-  int r = emscripten_resize_heap(old_size + (size_t) change_in_bytes);
+  if (!emscripten_resize_heap(old_size + (size_t) change_in_bytes)) {
+    return napi_set_last_error(env, napi_generic_failure, 0, NULL);
+  }
 
   *adjusted_value = (int64_t) emscripten_get_heap_size();
 

diff --git a/packages/emnapi/src/uv/unix/thread.c b/packages/emnapi/src/uv/unix/thread.c
@@ -94,7 +94,6 @@ int uv_thread_create_ex(uv_thread_t* tid,
                         void (*entry)(void *arg),
                         void *arg) {
   int err;
-  pthread_attr_t attr_storage;
 
   /* Used to squelch a -Wcast-function-type warning. */
   union {

diff --git a/packages/emnapi/src/uv/uv-common.c b/packages/emnapi/src/uv/uv-common.c
@@ -20,7 +20,7 @@ uv_loop_t* uv_default_loop(void) {
 }
 
 int uv_loop_close(uv_loop_t* loop) {
-  QUEUE* q;
+  // QUEUE* q;
   // uv_handle_t* h;
 #ifndef NDEBUG
   void* saved_data;

diff --git a/packages/test/cgen.config.js b/packages/test/cgen.config.js
@@ -2,6 +2,7 @@ module.exports = function (_options, { isDebug, isEmscripten }) {
   const compilerFlags = isEmscripten
     ? [
         // ...(isDebug ? ['-sDISABLE_EXCEPTION_CATCHING=0'] : [])
+        ...(isDebug ? ['-Wall'] : []),
         ...(process.env.MEMORY64 ? ['-sMEMORY64=1'] : [])
       ]
     : []