Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

設定画面スタンプタブの改修 #4141

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Conversation

mehm8128
Copy link
Member

@mehm8128 mehm8128 commented Nov 5, 2023

#2203
close #291

動作確認するべきこと

  • スタンプの追加ができる
    • 画像の編集も含む
  • スタンプの編集ができる
    • 名前・所有者
  • スタンプの画像更新ができる
    • 新しく選んだ画像の画像編集も含む
  • スタンプの削除ができる
  • (できれば)adminが全てのスタンプを見ることができる
  • (できれば)adminが他人のスタンプの所有者を変えることができる
  • (できれば)adminが他人のスタンプの編集や削除ができる

不明点
ここのATabで背景色のz-index-1に指定されていることが原因っぽくて背景色が表示されていないのですが、どうすればいいですか
image

@mehm8128 mehm8128 self-assigned this Nov 5, 2023
Copy link

github-actions bot commented Nov 5, 2023

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.35%. Comparing base (2075787) to head (d50e32d).
Report is 78 commits behind head on master.

❗ Current head d50e32d differs from pull request most recent head dedaffb. Consider uploading reports for the commit dedaffb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4141      +/-   ##
==========================================
- Coverage   86.36%   86.35%   -0.01%     
==========================================
  Files          66       66              
  Lines        4722     4719       -3     
  Branches      565      564       -1     
==========================================
- Hits         4078     4075       -3     
  Misses        638      638              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mehm8128 mehm8128 marked this pull request as ready for review December 27, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

スタンプ編集(管理者)
1 participant