Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/jit fusion #1750

Merged
merged 5 commits into from May 13, 2024
Merged

Refactor/jit fusion #1750

merged 5 commits into from May 13, 2024

Conversation

nathanielsimard
Copy link
Member

The goal is to make the reading and write position of each operation explicit so we can actually customize that part with further fusion.

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 95.02488% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 86.61%. Comparing base (5bbc5ea) to head (91e6c1d).

Files Patch % Lines
...burn-jit/src/codegen/dialect/gpu/procedure/read.rs 63.63% 4 Missing ⚠️
crates/burn-jit/src/codegen/compilation.rs 88.00% 3 Missing ⚠️
crates/burn-jit/src/codegen/dialect/gpu/scope.rs 93.54% 2 Missing ⚠️
...urn-jit/src/codegen/dialect/gpu/procedure/write.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1750      +/-   ##
==========================================
- Coverage   86.61%   86.61%   -0.01%     
==========================================
  Files         700      700              
  Lines       83427    83477      +50     
==========================================
+ Hits        72257    72300      +43     
- Misses      11170    11177       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanielsimard nathanielsimard merged commit 9dcec0b into main May 13, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the refactor/jit-fusion branch May 13, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants