Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add branch pipeline. #4890

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Conversation

grignards
Copy link
Collaborator

See #4886.

Checkpoints

For developers

  • If relevant, manual tests have been done to ensure the stability of the whole application and that the involved feature works
  • The original issue is up to date w.r.t the latest discussions and contains a short summary of the implemented solution
  • Automated tests covering the feature or the fix, have been written, deemed irrelevant (give the reason), or an issue has been created to implement the test (give the link)
  • Make sure that:
    • if there are modifications in the Tracim configuration files (eg. development.ini), they are documented in backend/doc/setting.md
    • any migration process required for existing instances is documented
    • relevant people for these changes are notified
  • Original authors of the features included in a multi-feature branch (maintenance fixes -> develop, security fixes -> develop, …) should be part of the reviewers, especially if you encountered merge conflicts.

For code reviewers

  • The code is clear enough
  • If there are FIXMEs in the code, related issues are mentioned in the FIXME
  • If there are TODOs, NOTEs or HACKs in code, the date and the developer initials are present

For testers

  • Manual, quality tests have been done

@PhilippeAccorsi
Copy link
Collaborator

@grignards this PR is to improve concourse-ci ? If yes, I think we can merge without reviewers because we need to improve the ci quickly. if the four commits not improve ci for the moment, I understund to not merge this now.

@grignards grignards force-pushed the misc/4886__branch_pipeline branch 5 times, most recently from 079acde to 39b582e Compare October 28, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants