Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade email signature + remove 'suricate' personification #6456

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

lebouquetin
Copy link
Contributor

@lebouquetin lebouquetin commented Apr 24, 2024

Checkpoints

For developers

  • If relevant, manual tests have been done to ensure the stability of the whole application and that the involved feature works
  • The original issue is up to date w.r.t the latest discussions and contains a short summary of the implemented solution
  • Automated tests covering the feature or the fix, have been written, deemed irrelevant (give the reason), or an issue has been created to implement the test (give the link)
  • Make sure that:
    • if there are modifications in the Tracim configuration files (eg. development.ini), they are documented in backend/doc/setting.md
    • any migration process required for existing instances is documented
    • relevant people for these changes are notified
  • Original authors of the features included in a multi-feature branch (maintenance fixes -> develop, security fixes -> develop, …) should be part of the reviewers, especially if you encountered merge conflicts.

For code reviewers

  • The code is clear enough
  • If there are FIXMEs in the code, related issues are mentioned in the FIXME
  • If there are TODOs, NOTEs or HACKs in code, the date and the developer initials are present

For testers

  • Manual, quality tests have been done

@lebouquetin
Copy link
Contributor Author

@Skylsmoi here comes the e-mail template upgrade. I removed all "Suricat' your digital xxx" + upgraded the signature in order to show it in gray and small.

I did not upgrade french and maybe other translations related to email templates. I don't know how to do so; could you show me?

@lebouquetin lebouquetin changed the title upgrade email signature + remove 'suricat' personification upgrade email signature + remove 'suricate' personification May 29, 2024
@lebouquetin
Copy link
Contributor Author

@Millefeuille42 @Skylsmoi do you know why backend-tests are broken?

It looks like it is related to video alert plugin:

./official_plugins/tracim_backend_video_alert/__init__.py:21:5: BLK100 Black would make changes.
               "with the built-in video player. We suggest you choose an MP4 or WebM video file.",

How can I restart the CI ?

@lebouquetin
Copy link
Contributor Author

choukran @Millefeuille42

@Millefeuille42
Copy link
Member

Millefeuille42 commented May 30, 2024

@lebouquetin Could you tick your "for the developer" boxes please ? Or I can do it for you ?

@Millefeuille42 Millefeuille42 added this to To/Under review in Tracim v4.10.0 May 30, 2024
@Millefeuille42 Millefeuille42 moved this from To/Under review to Need test on branch in Tracim v4.10.0 Jun 3, 2024
@Skylsmoi Skylsmoi moved this from Need test on branch to Under test on branch in Tracim v4.10.0 Jun 5, 2024
@Skylsmoi
Copy link
Collaborator

Skylsmoi commented Jun 5, 2024

tested on branch

@Skylsmoi Skylsmoi merged commit a2174c3 into develop Jun 5, 2024
4 checks passed
@Skylsmoi Skylsmoi deleted the update_default_email_templates branch June 5, 2024 12:13
@Skylsmoi Skylsmoi moved this from Under test on branch to Done in Tracim v4.10.0 Jun 5, 2024
@Skylsmoi Skylsmoi moved this from Done to To close in Tracim v4.10.0 Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To close
Development

Successfully merging this pull request may close these issues.

None yet

3 participants