-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(back): delete from elasticsearch after true delete #6474
Merged
Millefeuille42
merged 5 commits into
develop
from
fix/6473__delete_from_elasticsearch_after_true_delete
Jun 5, 2024
Merged
fix(back): delete from elasticsearch after true delete #6474
Millefeuille42
merged 5 commits into
develop
from
fix/6473__delete_from_elasticsearch_after_true_delete
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backend/tracim_backend/lib/search/elasticsearch_search/elasticsearch_search.py
Outdated
Show resolved
Hide resolved
Millefeuille42
requested changes
Apr 30, 2024
backend/tracim_backend/lib/search/elasticsearch_search/elasticsearch_search.py
Show resolved
Hide resolved
backend/tracim_backend/lib/search/elasticsearch_search/elasticsearch_search.py
Outdated
Show resolved
Hide resolved
21 tasks
…ete_from_elasticsearch_after_true_delete
Millefeuille42
approved these changes
Jun 4, 2024
Skylsmoi
requested changes
Jun 4, 2024
backend/tracim_backend/lib/search/elasticsearch_search/elasticsearch_search.py
Outdated
Show resolved
Hide resolved
backend/tracim_backend/lib/search/elasticsearch_search/elasticsearch_search.py
Show resolved
Hide resolved
backend/tracim_backend/lib/search/elasticsearch_search/elasticsearch_search.py
Show resolved
Hide resolved
Skylsmoi
approved these changes
Jun 5, 2024
tested on branch |
Millefeuille42
deleted the
fix/6473__delete_from_elasticsearch_after_true_delete
branch
June 5, 2024 08:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6473
Checkpoints
For developers
development.ini
), they are documented inbackend/doc/setting.md
For code reviewers
For testers