Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(back): delete from elasticsearch after true delete #6474

Merged

Conversation

floreal15
Copy link
Collaborator

@floreal15 floreal15 commented Apr 26, 2024

#6473

Checkpoints

For developers

  • If relevant, manual tests have been done to ensure the stability of the whole application and that the involved feature works
  • The original issue is up to date w.r.t the latest discussions and contains a short summary of the implemented solution
  • Automated tests covering the feature or the fix, have been written, deemed irrelevant (give the reason), or an issue has been created to implement the test (give the link)
  • Make sure that:
    • if there are modifications in the Tracim configuration files (eg. development.ini), they are documented in backend/doc/setting.md
    • any migration process required for existing instances is documented
    • relevant people for these changes are notified
  • Original authors of the features included in a multi-feature branch (maintenance fixes -> develop, security fixes -> develop, …) should be part of the reviewers, especially if you encountered merge conflicts.

For code reviewers

  • The code is clear enough
  • If there are FIXMEs in the code, related issues are mentioned in the FIXME
  • If there are TODOs, NOTEs or HACKs in code, the date and the developer initials are present

For testers

  • Manual, quality tests have been done

@Millefeuille42 Millefeuille42 changed the base branch from develop to maintenance/4.9 May 2, 2024 13:46
@Millefeuille42 Millefeuille42 deleted the branch develop May 2, 2024 13:53
@Millefeuille42 Millefeuille42 reopened this May 2, 2024
@floreal15 floreal15 changed the base branch from maintenance/4.9 to develop June 3, 2024 14:34
@Millefeuille42
Copy link
Member

tested on branch

@Millefeuille42 Millefeuille42 merged commit 3243754 into develop Jun 5, 2024
4 checks passed
@Millefeuille42 Millefeuille42 deleted the fix/6473__delete_from_elasticsearch_after_true_delete branch June 5, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants