Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/6250 configurable dropdown action in apps #6491

Merged
merged 24 commits into from
May 22, 2024

Conversation

Skylsmoi
Copy link
Collaborator

@Skylsmoi Skylsmoi commented May 14, 2024

#6250

Checkpoints

For developers

  • If relevant, manual tests have been done to ensure the stability of the whole application and that the involved feature works
  • The original issue is up to date w.r.t the latest discussions and contains a short summary of the implemented solution
  • Automated tests covering the feature or the fix, have been written, deemed irrelevant (give the reason), or an issue has been created to implement the test (give the link)
  • Make sure that:
    • if there are modifications in the Tracim configuration files (eg. development.ini), they are documented in backend/doc/setting.md
    • any migration process required for existing instances is documented
    • relevant people for these changes are notified
  • Original authors of the features included in a multi-feature branch (maintenance fixes -> develop, security fixes -> develop, …) should be part of the reviewers, especially if you encountered merge conflicts.

For code reviewers

  • The code is clear enough
  • If there are FIXMEs in the code, related issues are mentioned in the FIXME
  • If there are TODOs, NOTEs or HACKs in code, the date and the developer initials are present

For testers

  • Manual, quality tests have been done

backend/tracim_backend/views/core_api/schemas.py Outdated Show resolved Hide resolved
frontend_app_logbook/.gitignore Show resolved Hide resolved
frontend_app_file/src/container/File.jsx Outdated Show resolved Hide resolved
frontend_app_html-document/src/container/HtmlDocument.jsx Outdated Show resolved Hide resolved
frontend_app_html-document/src/container/HtmlDocument.jsx Outdated Show resolved Hide resolved
frontend_app_kanban/src/container/Kanban.jsx Outdated Show resolved Hide resolved
frontend_app_logbook/src/container/Logbook.jsx Outdated Show resolved Hide resolved
frontend_app_thread/src/container/Thread.jsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@PhilippeAccorsi PhilippeAccorsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about docker workflow.

The empty config file is it availble on first start, like we have with color.json or some other config file.

doc/backend/branding.md Outdated Show resolved Hide resolved
doc/backend/branding.md Outdated Show resolved Hide resolved
doc/backend/branding.md Outdated Show resolved Hide resolved
doc/backend/branding.md Outdated Show resolved Hide resolved
doc/backend/branding.md Outdated Show resolved Hide resolved
doc/backend/branding.md Show resolved Hide resolved
doc/backend/branding.md Show resolved Hide resolved
doc/backend/branding.md Outdated Show resolved Hide resolved
…filter + add user.public_name + app folder advanced + add backend log when config file not found or not json valid
@Millefeuille42
Copy link
Member

tested on branch, feedback has been reported on #6494

@Skylsmoi Skylsmoi merged commit 2f3c75e into develop May 22, 2024
1 check passed
@Skylsmoi Skylsmoi deleted the feat/6250__configurable_dropdown_action_in_apps branch May 22, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants