-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/6250 configurable dropdown action in apps #6491
Merged
Skylsmoi
merged 24 commits into
develop
from
feat/6250__configurable_dropdown_action_in_apps
May 22, 2024
Merged
Feat/6250 configurable dropdown action in apps #6491
Skylsmoi
merged 24 commits into
develop
from
feat/6250__configurable_dropdown_action_in_apps
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
…w component DropdownMenuItemCustomAction + refactor contentItem.jsx props + fix typo in name BtnExtendedAction.jsx + add doc + fix app custom action backend schema + add unit test for app custom action
… btn extended action + fix tests
PhilippeAccorsi
requested changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about docker workflow.
The empty config file is it availble on first start, like we have with color.json or some other config file.
PhilippeAccorsi
approved these changes
May 22, 2024
…filter + add user.public_name + app folder advanced + add backend log when config file not found or not json valid
Millefeuille42
approved these changes
May 22, 2024
tested on branch, feedback has been reported on #6494 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6250
Checkpoints
For developers
development.ini
), they are documented inbackend/doc/setting.md
For code reviewers
For testers