Quiet down TCP RST packet error on read operation #9007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtribotte
added
kind/enhancement
2 tasks
tomMoulard
reviewed
May 13, 2022
Co-authored-by: Tom Moulard <tom@moulard.org>
kevinpollet
force-pushed
the
quiet-tcp-rst-packet-error-log
branch
from
5343d75
to
33a892f
Compare
kevinpollet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR decreases the log level for some errors in the TCP proxy.
It changes to debug level errors due to the reception of an RST packet during a read operation.
It also quiets completely further errors on connection closing if the socket is already disconnected.
Motivation
The PR avoids confusion, when one peer is shutting down the connection abruptly with an RST packet, by having the related error logged as debug only.
Fixes #8737
More