Load plugin configuration field value from Kubernetes Secret #9103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtribotte
added
kind/enhancement
2 tasks
|
Thanks, @kevinpollet, and @rtribotte for this. I appreciate it very much since I think this is a very needing feature. |
mpl
approved these changes
Jun 16, 2022
ldez
added
status/3-needs-merge
and removed
status/2-needs-review
status/3-needs-merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When declaring a middleware plugin with the Kubernetes CRD provider, it allows providing plugin configuration field values from a Kubernetes Secret.
The reference of the form
urn:k8s:secret:secretName:secretKeyis then replaced by the secret value if found, otherwise an error is thrown.Motivation
Supersedes #8995
Fixes #8994
More
Additional Notes
Co-authored-by: nnlquan longquan0104@gmail.com