Move consulcatalog provider to only use health apis #9140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpollet
added
kind/enhancement
1 task
rtribotte
approved these changes
Jun 29, 2022
tomMoulard
added
status/2-needs-review
and removed
status/3-needs-merge
bot/need-human-merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR drops the usage of the Catalog API within the Consul Catalog provider and switches to only using the Health API(s). This is nicely compatible with the Connect endpoints as they live under the same API and output exactly the same types.
Motivation
The Health API, with the cache query parameter set to
true, uses the streaming health check system. This means that if streaming is enabled in a Consul cluster, Traefik is now effectively 'free' to run, going so far as an operator can set the refresh interval down to 1 second and likely not notice anything in their Consul cluster.Even if streaming is disabled, this still cuts the request rate in half, meaning$\approx\frac{1}{2}$ bandwidth usage on top of that which is helpful in really large clusters.
Supersedes #8834
More
Additional Notes
Co-authored-by: Charles Zaffery czaffery@roblox.com