Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACME Default Certificate #9189

Merged
merged 12 commits into from Sep 13, 2022
Merged

Conversation

rtribotte
Copy link
Member

@rtribotte rtribotte commented Jul 13, 2022

What does this PR do?

This PR adds the capacity for a TLS Store to use an ACME provider (like Let's Encrypt) to generate the default certificate.

Motivation

Fixes #8123.
Supersedes #8124.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: Ludovic Fernandez ldez@users.noreply.github.com
Co-authored-by: Julien Salleyron julien.salleyron@gmail.com

Copy link

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code comments & docs clarification requests...

docs/content/https/tls.md Outdated Show resolved Hide resolved
docs/content/https/tls.md Outdated Show resolved Hide resolved
docs/content/https/tls.md Outdated Show resolved Hide resolved
docs/content/https/tls.md Outdated Show resolved Hide resolved
pkg/provider/acme/provider.go Outdated Show resolved Hide resolved
pkg/provider/acme/provider.go Outdated Show resolved Hide resolved
pkg/provider/acme/provider.go Outdated Show resolved Hide resolved
@ldez ldez marked this pull request as draft September 12, 2022 16:03
@ldez ldez force-pushed the feat-acme-default-cert branch 4 times, most recently from e461409 to 0e76213 Compare September 13, 2022 11:15
@ldez ldez marked this pull request as ready for review September 13, 2022 13:37
@ldez ldez force-pushed the feat-acme-default-cert branch 2 times, most recently from 1f038ed to d3a47e5 Compare September 13, 2022 14:14
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/provider/acme/provider.go Show resolved Hide resolved
pkg/provider/acme/provider.go Outdated Show resolved Hide resolved
pkg/provider/acme/provider.go Outdated Show resolved Hide resolved
pkg/tls/certificate.go Show resolved Hide resolved
pkg/provider/acme/provider.go Show resolved Hide resolved
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit a002ccf into traefik:master Sep 13, 2022
v2 automation moved this from To review to Done Sep 13, 2022
@rtribotte rtribotte deleted the feat-acme-default-cert branch September 14, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

Allow assuming default host if no SNI indication is given (for Let's Encrypt)
7 participants