Add support for reaching containers using host networking on Podman #9190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddtmachado
added
kind/enhancement
kevinpollet
added
status/2-needs-review
and removed
status/1-needs-design-review
labels
kevinpollet
force-pushed
the
featue-podman-gateway
branch
from
3978f6c
to
4884eab
Compare
kevinpollet
force-pushed
the
featue-podman-gateway
branch
from
38ed9d0
to
723bd78
Compare
kevinpollet
changed the title
Closed
mpl
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for reaching containers using host networking on systems using podman by allowing traefik to correctly detect the podman gateway.
On docker traefik detects the gateway by looking up
host.docker.internal. Podman doesn't support thehost.docker.internaldomain, but added support forhost.containers.internalin containers/podman#9972 instead.Without this PR podman users would have to manually set
host.docker.internalusing add-host/extra_hosts.Motivation
I'm using traefik on a server running podman and ran into this issue.
Related to #5730
More
Additional Notes
It would also be possible so solve this using a loop, but because there are only two domains I think that it is more readable without one. Should more domains be needed in the future I would recommend using a loop here.