Support Nomad canary deployment #9216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtribotte
added
kind/enhancement
2 tasks
|
I have tested it and it works great 👍 |
apollo13
reviewed
Jul 29, 2022
kevinpollet
reviewed
Aug 1, 2022
kevinpollet
reviewed
Aug 1, 2022
ldez
approved these changes
Aug 1, 2022
mpl
approved these changes
Aug 1, 2022
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for Nomad canary deployment.
Motivation
When Nomad orchestrator is a provider (of service registration) for Traefik,
one might have the need to distinguish within Traefik between a Canary instance of a service, or a production one.
For example if one does not want them to be part of the same load-balancer.
Therefore, this option, which is meant to be provided as one of the values of the
canary_tagsfield in the Nomad service stanza, allows Traefik to identify that the associated instance is a canary one.Fixes #8987
Supersedes #9012
More
Additional Notes
Co-authored-by: Kevin Pollet pollet.kevin@gmail.com
Co-authored-by: Mathieu Lonjaret mathieu.lonjaret@gmail.com